Ensure exceptions can get passed back from JS-Bridge to that a descriptive error can be received#1
Open
ofentsephajane wants to merge 2 commits intofusecx:mainfrom
Open
Ensure exceptions can get passed back from JS-Bridge to that a descriptive error can be received#1ofentsephajane wants to merge 2 commits intofusecx:mainfrom
ofentsephajane wants to merge 2 commits intofusecx:mainfrom
Conversation
…ToNative, logCustomEvent, and logPurchase methods
…assed-back-to-JS-bridge-so-that-they-receive-a-descriptive-error chore: enhance error handling and return descriptive messages in send…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
BrazeJavascriptBridgeclass to make its communication methods asynchronous and improve error handling. The most important changes are grouped below:Async refactoring of bridge methods:
sendToNative,logCustomEvent, andlogPurchasemethods to be asynchronous (async) and to return results, allowing callers to await the response from the Flutter native layer. [1] [2] [3] [4]Improved error handling and response structure:
sendToNativeto return structured JSON error messages instead of logging errors and returning nothing, making it easier for consumers to handle errors programmatically. [1] [2]